Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sell_stale.json.example is incomplete #1

Open
skoenig opened this issue Mar 6, 2018 · 0 comments
Open

sell_stale.json.example is incomplete #1

skoenig opened this issue Mar 6, 2018 · 0 comments

Comments

@skoenig
Copy link

skoenig commented Mar 6, 2018

If I rename and use the default sell_stale.json.example config file, I encounter this exception:

./src/investhor/scripts/sell.py 
Traceback (most recent call last):
  File "./src/investhor/scripts/sell.py", line 108, in <module>
    main()
  File "./src/investhor/scripts/sell.py", line 89, in main
    discount = params[discount_name]
KeyError: 'no_discount'

Seems like the example config file is missing some parameters and they are also not documented.

skoenig added a commit to skoenig/investhor that referenced this issue Oct 24, 2018
The example config file for `sell.py` was missing some parameters, what caused exceptions when using this config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant