Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot specify redirect_uri #4

Open
mmahalwy opened this issue Jan 24, 2016 · 7 comments
Open

cannot specify redirect_uri #4

mmahalwy opened this issue Jan 24, 2016 · 7 comments

Comments

@mmahalwy
Copy link
Contributor

I thought this library would be great as a work around the problem with postmessage and the google javascript auth. But I found that this completely changes my flow of my API backend because it assumes an application credential and cannot be shared with my web browser app credentials.

Can this be achieved with redirect_uri postmessage?

@parro-it
Copy link
Owner

Hi, @gotokatsuya has implemented that in a PR. Pls wait for that PR to land in master.

@parro-it
Copy link
Owner

And ping me here if the redirect_uri PR doesn't fix your user case.

@mmahalwy
Copy link
Contributor Author

Will I be able to use postmessage?

@parro-it
Copy link
Owner

What do you mean by postmessage? Please add more details about your problem.

@mmahalwy
Copy link
Contributor Author

See Step 4 in: https://developers.google.com/identity/sign-in/web/server-side-flow

Ideally, I want to have postmessage to be set for redirecturi so that a one-time code is sent back from google upon successful auth, and sent to the server to retrieve the full data.

@parro-it
Copy link
Owner

Thanks you for the details. I read step 4 you've linked. Yes AFAIK mentioned PR should provide the feature you need. I reopen this to remember me to check when I'll merge the PR.

@parro-it parro-it reopened this Jan 27, 2016
@parro-it
Copy link
Owner

Tracking upstream issue electron/electron#1865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants