-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an example with the new metadata hash input #391
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
good first issue
Good for newcomers
Comments
IkerAlus
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
good first issue
Good for newcomers
labels
Jun 26, 2024
IkerAlus
changed the title
Add example metadata hash
Add an example with the new metadata hash input
Jun 26, 2024
If anyone wishes to make a PR for this, you are more than welcome to do so! The changes to the example would basically be adding an extra step to building the transaction:
This is not as straightforward of a change as it would seem on a first look, since it needs to add the metadata proof building step along with the corresponding PAPI package, but it's interesting to understand how the new SignedExtension works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
good first issue
Good for newcomers
Since Polkadot 1.2.5 release, signers can add the metadata hash to a transaction as specified in RFC 78.
Although txwrapper is not a signer, it is supposed to be used in conjunction with signers to construct transactions offline. Hence it will be good to add an example, for example similar to this one, where the metadata hash is added to the transaction before being signed. The open question is how to compute this hash value. My recommendation is not to add extra dependencies to the example and query it from the exposed testing API or similar
The text was updated successfully, but these errors were encountered: