You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 21, 2024. It is now read-only.
After the recent upgrade to version v0.9.40, the xcm-simulator was not updated to align with the changes. As a result, the tests in the simulator are broken, preventing the creation of any new tests.
Proposed Solution:
To address this issue, we need to update the configuration of the mocks within the simulator and adjust the tests accordingly. These changes are crucial for effectively testing the modifications introduced in issue #215.
Additional Consideration:
It might be beneficial to include the xcm-simulator in the workspace to enable tools like rust-analyzer and other linters to detect errors within that directory. However, it's important to note that this inclusion may lead to increased compilation times and potential slowdowns in the overall performance of the linters. What is your opinion on this?
Totally agree, with the current setup for the simulator, migrating all the mock runtime and the tests to v0.9.40 becomes really painful and error-prone. Also maintaining this code on the long term will become harder and harder.
Switching to the emulator would result in an overall simplification of this, and would allow us to focus on the testing rather than spending time on the configuration of the actual runtimes.
hbulgarini
changed the title
Fix xcm-simulator configuration
Decommission xcm-simulator and replace it for xcm-emulator
Jun 7, 2023
Description:
After the recent upgrade to version v0.9.40, the xcm-simulator was not updated to align with the changes. As a result, the tests in the simulator are broken, preventing the creation of any new tests.
Proposed Solution:
To address this issue, we need to update the configuration of the mocks within the simulator and adjust the tests accordingly. These changes are crucial for effectively testing the modifications introduced in issue #215.
Additional Consideration:
It might be beneficial to include the xcm-simulator in the workspace to enable tools like rust-analyzer and other linters to detect errors within that directory. However, it's important to note that this inclusion may lead to increased compilation times and potential slowdowns in the overall performance of the linters. What is your opinion on this?
CC: @hbulgarini, @stiiifff , @kalaninja
The text was updated successfully, but these errors were encountered: