Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Decommission xcm-simulator and replace it for xcm-emulator #217

Open
valentinfernandez1 opened this issue Jun 7, 2023 · 6 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@valentinfernandez1
Copy link
Contributor

valentinfernandez1 commented Jun 7, 2023

Description:

After the recent upgrade to version v0.9.40, the xcm-simulator was not updated to align with the changes. As a result, the tests in the simulator are broken, preventing the creation of any new tests.

Proposed Solution:

To address this issue, we need to update the configuration of the mocks within the simulator and adjust the tests accordingly. These changes are crucial for effectively testing the modifications introduced in issue #215.

Additional Consideration:

It might be beneficial to include the xcm-simulator in the workspace to enable tools like rust-analyzer and other linters to detect errors within that directory. However, it's important to note that this inclusion may lead to increased compilation times and potential slowdowns in the overall performance of the linters. What is your opinion on this?

CC: @hbulgarini, @stiiifff , @kalaninja

@valentinfernandez1 valentinfernandez1 added the bug Something isn't working label Jun 7, 2023
@valentinfernandez1 valentinfernandez1 changed the title Fix xcm -simulator Configuration Fix xcm-simulator configuration Jun 7, 2023
@valentinfernandez1
Copy link
Contributor Author

In the future we could also include the xcm-emulator

@hbulgarini
Copy link
Contributor

IMHO, we should deprecate the xcm-simulator and move xcm-emulator using the real runtimes.

Also, these tests should be migrated as well.

@valentinfernandez1
Copy link
Contributor Author

Totally agree, with the current setup for the simulator, migrating all the mock runtime and the tests to v0.9.40 becomes really painful and error-prone. Also maintaining this code on the long term will become harder and harder.

Switching to the emulator would result in an overall simplification of this, and would allow us to focus on the testing rather than spending time on the configuration of the actual runtimes.

@hbulgarini hbulgarini changed the title Fix xcm-simulator configuration Decommission xcm-simulator and replace it for xcm-emulator Jun 7, 2023
@hbulgarini hbulgarini self-assigned this Jun 7, 2023
@hbulgarini
Copy link
Contributor

I’m taking this one as I’m working already to debug an issue with the barrier set up.

@hbulgarini
Copy link
Contributor

PR #222 is a first step into the migration of the simulator to the emulator.

Still, this issue should remain open since we need to migrate the existing tests from the xcm-simulator.

@metricaez
Copy link
Collaborator

Hey, I had invested a little time with the emulator so I am taking this one over so we can close it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants