Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix Staking Version in Genesis #9280

Merged
1 commit merged into from
Jul 6, 2021
Merged

Conversation

shawntabrizi
Copy link
Member

@shawntabrizi shawntabrizi commented Jul 6, 2021

When bumping the staking pallet storage from v6 to v7, the genesis version didn't get changed.

This fixes that. New runtimes using the pallet for the first time will have the latest storage version, which is v7.0.0

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jul 6, 2021
@shawntabrizi shawntabrizi requested a review from emostov July 6, 2021 03:24
Copy link
Contributor

@emostov emostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Are there any plans for some migration abstractions that would lend themselves to best practices?

For migrations that go the storage version route there seems to be some easy to miss stuff like this.

@shawntabrizi
Copy link
Member Author

@emostov look at #9165

@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 6, 2021
@shawntabrizi
Copy link
Member Author

bot merge

@ghost
Copy link

ghost commented Jul 6, 2021

Trying merge.

@ghost ghost merged commit 8c868a2 into master Jul 6, 2021
@ghost ghost deleted the shawntabrizi-staking-version-genesis branch July 6, 2021 06:08
dvdplm added a commit that referenced this pull request Jul 6, 2021
* master:
  fix staking version in genesis (#9280)
  fix storage info for decl_storage (#9274)
  Authority_discovery: expose assimilate_storage with GenesisBuild (#9279)
  Update CODEOWNERS (#9278)
  Remove in-tree `max-encoded-len` and use the new SCALE codec crate instead (#9163)
  bump a bunch of deps in parity-common (#9263)
  Bump linregress due to security vulnerability (#9262)
  pallet macro: always generate storage info on pallet struct (#9246)
  Less duplication in test code (#9270)
  Add `Chilled` event to staking chill extrinsics (#9250)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants