-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
This is required to make the `well_know_keys::ACTIVE_CONFIG` match the `ActiveConfig` key.
Oh, I am not familiar with this |
Yeah I know and that didn't catch this :P We changed this to The |
Meaning that this replaces the existing test? If so, could you please remove it? Or is it still valuable? |
It still tests if the stuff decodes and contains the expected values. I would still see this somewhat useful. |
But I also can remove it. |
(It still ensures that the type of |
I talked to @pepyakin yesterday about this, and mentioned it would make sense to me for this to be a custom key from end to end, rather than a pallet storage item (which can be changed from frame version to frame version) |
I'm clearly not happy with the status, but it is the easiest solution for now. In the future we really need to have some better utility for parachains to make use of this. As outlined here paritytech/polkadot-sdk#82 by @pepyakin |
bot merge |
Waiting for commit status. |
This is required to make the
well_know_keys::ACTIVE_CONFIG
match theActiveConfig
key.