fix(cmd bench-omni): build omni-bencher with production profile #7299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
iulianbarbu
added
the
R0-silent
|
/cmd bench --runtime westend --pallets pallet_balances |
|
Command "bench --runtime westend --pallets pallet_balances" has started 🚀 See logs here |
|
Command "bench --runtime westend --pallets pallet_balances" has finished ✅ See logs here |
|
/cmd bench --runtime westend --pallet pallet_balances |
|
Command "bench --runtime westend --pallet pallet_balances" has started 🚀 See logs here |
…llet pallet_balances'
|
Command "bench --runtime westend --pallet pallet_balances" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
|
/cmd bench-omni --runtime westend --pallet pallet_balances |
|
Command "bench-omni --runtime westend --pallet pallet_balances" has started 🚀 See logs here |
… --pallet pallet_balances'
|
Command "bench-omni --runtime westend --pallet pallet_balances" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
iulianbarbu
changed the title
|
@iulianbarbu if I compare 2 commits b/w each other - i see that bench-omni is still 30% worse as it was before with threshold 2 it shows all of them degraded |
Looks like the commits are from paritytech/polkadot-sdk. Wouldn't the comparisons use the omni-bencher built w/o the prod profile, so the results make sense? In any case, seems like the commits refer to my previous attempts to reproduce your issue on this branch, on this repo, on this org, while my actual fixing/testing happened on paritytech-stg. Fixing master on paritytech is based on the results of the tests from paritytech-stg. |
|
@iulianbarbu you're right! I didn't think that it's a context of paritytech and this change is still pulling from master |
mordamax
approved these changes
Jan 24, 2025
iulianbarbu
changed the title
bkchr
approved these changes
Jan 24, 2025
bkontur
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR builds frame-omni-bencher with
productionprofile when calling/cmd bench-omnito compute benchmarks for pallets.Fix proposed by @bkchr , thanks!
Closes #6797.
Integration
N/A
Review Notes
More info on #6797, and related to how the fix was tested: #6797 (comment).