Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove collation-generation subsystem from validator nodes #6476

Closed
alindima opened this issue Nov 14, 2024 · 5 comments · Fixed by #6832
Closed

Remove collation-generation subsystem from validator nodes #6476

alindima opened this issue Nov 14, 2024 · 5 comments · Fixed by #6832
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder.

Comments

@alindima
Copy link
Contributor

As the title says:

polkadot-sdk/polkadot/node/service/src/overseer.rs

Line 298 in a1af8ed

.collation_generation(CollationGenerationSubsystem::new(Metrics::register(registry)?))

Collation-generation is only needed for collators
@alindima alindima added D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Nov 14, 2024
@burdges
Copy link

burdges commented Nov 15, 2024

We'd do a validator DKG by having validators make blocks on a parathread, but this could always be brought back for that.

@ndkazu
Copy link
Contributor

ndkazu commented Nov 30, 2024 •
edited
Loading

Hello,
If I understood correctly the assignment is basically removing .collation_generation from /polkadot/node/service/src/overseer.rs - validator_overseer_builder & validator_with_parallel_overseer_builder. Is that right ?

@ndkazu ndkazu mentioned this issue Dec 10, 2024
Merged
@ndkazu
Copy link
Contributor

ndkazu commented Dec 10, 2024

Hello, I removed collation_generation from validator nodes, and the tests seem to be ok. Please check the linked PR.

@ndkazu
Copy link
Contributor

ndkazu commented Dec 11, 2024 •
edited
Loading

Hello, I removed collation_generation from validator nodes, and the tests seem to be ok. Please check the linked PR.

Tests are still failing, I will keep searching...but basically, I am trying to understand how to use the orchestra-proc-macro crate.

@ndkazu
Copy link
Contributor

ndkazu commented Dec 11, 2024

Hello, I removed collation_generation from validator nodes, and the tests seem to be ok. Please check the linked PR.

Tests are still failing, I will keep searching...but basically, I am trying to understand how to use the orchestra-proc-macro crate.

collation_generation removed for validators, all tests are good, & CI is OK ⇨ Ready for approval.
I However have to admit that I still don't fully understand the use of the orchestra-proc-macro crate 😞 .
I guess I will keep reading the doc together with the Polkadot-sdk until it clicks... 🤔

@alindima alindima linked a pull request Dec 12, 2024 that will close this issue
Remove collation-generation subsystem from validator nodes #6832
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 12, 2024
@ndkazu @bkchr
@dmitry-markin @lexnv
Remove collation-generation subsystem from validator nodes (#6832)
50e5dd2 
# Description
Issue #6476 
Collation-generation is not needed for validators node, and should be
removed.

## Implementation
Use a `DummySubsystem` for `collation_generation`

---------

Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Dmitry Markin <[email protected]>
Co-authored-by: Alexandru Vasile <[email protected]>
@github-project-automation github-project-automation bot moved this from Backlog to Completed in parachains team board Dec 12, 2024
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025
@ndkazu @bkchr
@dmitry-markin @lexnv @dudo50
Remove collation-generation subsystem from validator nodes (paritytec…
f2c078b 
…h#6832)

# Description
Issue paritytech#6476 
Collation-generation is not needed for validators node, and should be
removed.

## Implementation
Use a `DummySubsystem` for `collation_generation`

---------

Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Dmitry Markin <[email protected]>
Co-authored-by: Alexandru Vasile <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder.
Projects
parachains team board
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove collation-generation subsystem from validator nodes ndkazu/polkadot-sdk
3 participants
@burdges @alindima @ndkazu