-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding rust-toolchain.toml to the repo #5335
Comments
Yeah, when we switched to GHA we can do this switch. Basically the docker image could have the Rust version pre-installed, but the actual version is determined by the |
It is still possible to use |
Just fyi, rust version can be found in the CI image name here |
Yep, that is exactly how I found it |
Hello folks, I'd like some advice on what would be needed in the rust-toolchain.toml file. I've made a basic example here in my PR, which will be used by the getting-started script, and I'm not familiar enough with the entire project's requirements. |
I suggest using PRR in the release pipeline if transitioning to GHA. PRR is specifically designed for releasing runtimes based on the Polkadot SDK and provides robust support for |
I understand that you use nightly compiler (which version?) for formatting purposes and stable (which version?) for compilation.
When contributing it is somewhat painful to see huge number of warnings caused by project using different (older) version of the compiler.
rust-toolchain.toml
will fix at least compilation warnings by ensuring everyone is using exactly the same version without digging into your GitLab pipelines trying to figure out what you happen to use for linting (today it happens to be 1.77.0).The text was updated successfully, but these errors were encountered: