-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make on_idle
WeightMeter factor in block size
#4743
Labels
I2-bug
The node fails to follow expected behavior.
Comments
3 tasks
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Jun 14, 2024
Fix #4743 which allows us to remove the defensive limit on pov size in Cumulus after relay chain gets upgraded with these changes. Also add unit test to ensure `CheckWeight` - `StorageWeightReclaim` integration works. TODO: - [x] PRDoc - [x] Add a len to all the other tests in storage weight reclaim and call `CheckWeight::pre_dispatch` --------- Signed-off-by: Andrei Sandu <[email protected]>
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this issue
Aug 2, 2024
Fix paritytech#4743 which allows us to remove the defensive limit on pov size in Cumulus after relay chain gets upgraded with these changes. Also add unit test to ensure `CheckWeight` - `StorageWeightReclaim` integration works. TODO: - [x] PRDoc - [x] Add a len to all the other tests in storage weight reclaim and call `CheckWeight::pre_dispatch` --------- Signed-off-by: Andrei Sandu <[email protected]>
sfffaaa
pushed a commit
to peaqnetwork/polkadot-sdk
that referenced
this issue
Dec 27, 2024
Fix paritytech#4743 which allows us to remove the defensive limit on pov size in Cumulus after relay chain gets upgraded with these changes. Also add unit test to ensure `CheckWeight` - `StorageWeightReclaim` integration works. TODO: - [x] PRDoc - [x] Add a len to all the other tests in storage weight reclaim and call `CheckWeight::pre_dispatch` --------- Signed-off-by: Andrei Sandu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We want to get rid of the current defensive limit on pov size defined here:
polkadot-sdk/cumulus/client/consensus/aura/src/collators/lookahead.rs
Line 394 in cdb297b
With #4326 in place we are already close.
There is one more scenario we need to fix before we can safely enable the full size there. It can happen that on_idle consumes more weight than what is available and exceed the PoV size.
Example for this scenario:
CheckWeight
SE: Check for extrinsic length + proof size combined #4326 reports that that no more extrinsics can be included in a block because weight + block length exceed the PoV size.on_idle
hook defined that gets called with the rest weight. However, since block length and storage proof weight are tracked separately, the remaining weight passed toon_idle
will be too high.Solutions:
CheckWeight
SE: Check for extrinsic length + proof size combined #4326. If we go this route one needs to double check the pov-reclaim logic for adjustments.The text was updated successfully, but these errors were encountered: