Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ribbon to substrate-website #13

Closed
Tracked by #10
mordamax opened this issue Aug 29, 2024 · 4 comments
Closed
Tracked by #10

Add a ribbon to substrate-website #13

mordamax opened this issue Aug 29, 2024 · 4 comments
Assignees

Comments

@mordamax
Copy link
Collaborator

mordamax commented Aug 29, 2024

polkadot-developers/substrate-docs#2172 (comment)

@mordamax mordamax changed the title add a ribbon to substrate-website https://github.com/polkadot-developers/substrate-docs/pull/2172#issuecomment-2315642856 Add a ribbon to substrate-website Aug 29, 2024
@paritytech paritytech deleted a comment from wahyu-n Aug 29, 2024
@paritytech paritytech deleted a comment from rodeok Aug 29, 2024
@mordamax
Copy link
Collaborator Author

@kianenigma do you have an idea what kind of copy to put there?

@mordamax mordamax self-assigned this Aug 29, 2024
@kianenigma
Copy link

Hmm not an expert 😁 but anything aligned with what current banner is okay.

Once your PR is up I'd happily help out.

@rzadp
Copy link

rzadp commented Sep 3, 2024

I found that there exists a functionality to provide banners through this JSON file, so it could be done quickly just by adding an entry.

So I proposed paritytech/substrate-website-banner#11

However, it doesn't show on mobile, so I'll also look for a different approach to inform mobile users.

@rzadp
Copy link

rzadp commented Sep 13, 2024

Banners are up:

Desktop

Screenshot 2024-09-13 at 16 41 04


Screenshot 2024-09-13 at 16 40 44

Mobile

2024-09-13 16 40 54


2024-09-13 16 40 51

@rzadp rzadp closed this as completed Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants