Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add relay parent to inherent and to digest #304

Conversation

JoshOrndorff
Copy link
Contributor

This is my attempt at solving paritytech/polkadot-sdk#83.

Feedback and suggestions welcome.

@bkchr
Copy link
Member

bkchr commented Jan 21, 2021

Ty for starting this!

So, I imagined it a little bit different. The digest is put as pre-runtime digest to the block in the collator implementation here:

Default::default(),

We would also need to check here that the pre-runtime digest exists:
https://github.com/paritytech/cumulus/blob/master/consensus/src/import_queue.rs

Regarding interfaces I would like to see something similar to this here:
https://github.com/paritytech/substrate/blob/master/primitives/consensus/babe/src/digests.rs#L158-L213

@JoshOrndorff
Copy link
Contributor Author

I might return to this, but I'm setting it aside for now. Thanks for the feedback on my initial draft.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants