diff --git a/pallets/evm-signatures/src/tests.rs b/pallets/evm-signatures/src/tests.rs index d68feb400..6bd424a2b 100644 --- a/pallets/evm-signatures/src/tests.rs +++ b/pallets/evm-signatures/src/tests.rs @@ -127,7 +127,6 @@ impl pallet_assets::Config for Runtime { type WeightInfo = (); type RemoveItemsLimit = frame_support::traits::ConstU32<1000>; type CallbackHandle = (); - #[cfg(feature = "runtime-benchmarks")] type BenchmarkHelper = (); } diff --git a/pallets/liquid-staking/src/benchmarking.rs b/pallets/liquid-staking/src/benchmarking.rs index a5e55bf83..9d63f3695 100644 --- a/pallets/liquid-staking/src/benchmarking.rs +++ b/pallets/liquid-staking/src/benchmarking.rs @@ -289,7 +289,7 @@ benchmarks! { Response::ExecutionResult(None) ) verify { - assert_last_event::(Event::::NotificationReceived(Box::new(MultiLocation::parent()), 0u64, None).into()); + assert_last_event::(Event::::NotificationReceived(Box::new(MultiLocation::parent()), 0u64, MaybeErrorCode::Success).into()); } claim_for { diff --git a/pallets/liquid-staking/src/lib.rs b/pallets/liquid-staking/src/lib.rs index 018329a2a..4acc83899 100644 --- a/pallets/liquid-staking/src/lib.rs +++ b/pallets/liquid-staking/src/lib.rs @@ -266,7 +266,7 @@ pub mod pallet { ExchangeRateUpdated(Rate), /// Notification received /// [multi_location, query_id, res] - NotificationReceived(Box, QueryId, Option<(u32, XcmError)>), + NotificationReceived(Box, QueryId, MaybeErrorCode), /// Claim user's unbonded staking assets /// [account_id, amount] ClaimedFor(T::AccountId, BalanceOf), @@ -771,9 +771,9 @@ pub mod pallet { .or_else(|_| { T::UpdateOrigin::ensure_origin(origin).map(|_| MultiLocation::here()) })?; - if let Response::ExecutionResult(res) = response { + if let Response::DispatchResult(res) = response { if let Some(request) = Self::xcm_request(query_id) { - Self::do_notification_received(query_id, request, res)?; + Self::do_notification_received(query_id, request, res.clone())?; } Self::deposit_event(Event::::NotificationReceived( @@ -1708,7 +1708,7 @@ pub mod pallet { fn do_notification_received( query_id: QueryId, req: XcmRequest, - res: Option<(u32, XcmError)>, + res: MaybeErrorCode, ) -> DispatchResult { use XcmRequest::*; @@ -1719,8 +1719,9 @@ pub mod pallet { &res ); - let executed = res.is_none(); - if !executed { + XcmRequests::::remove(query_id); + + if !matches!(res, MaybeErrorCode::Success) { return Ok(()); } @@ -1798,7 +1799,7 @@ pub mod pallet { } Nominate { targets: _, .. } => {} } - XcmRequests::::remove(query_id); + Ok(()) } diff --git a/pallets/prices/src/mock.rs b/pallets/prices/src/mock.rs index 243368597..4d623a8de 100644 --- a/pallets/prices/src/mock.rs +++ b/pallets/prices/src/mock.rs @@ -235,7 +235,6 @@ impl pallet_assets::Config for Test { type WeightInfo = (); type RemoveItemsLimit = frame_support::traits::ConstU32<1000>; type CallbackHandle = (); - #[cfg(feature = "runtime-benchmarks")] type BenchmarkHelper = (); } diff --git a/pallets/xcm-helper/src/lib.rs b/pallets/xcm-helper/src/lib.rs index cde4af9ac..f8f635a92 100644 --- a/pallets/xcm-helper/src/lib.rs +++ b/pallets/xcm-helper/src/lib.rs @@ -268,7 +268,7 @@ impl Pallet { let notify: ::RuntimeCall = notify.into(); let max_weight = notify.get_dispatch_info().weight; let query_id = pallet_xcm::Pallet::::new_notify_query(responder, notify, timeout, Here); - let report_error = Xcm(vec![ReportError(QueryResponseInfo { + let report_error = Xcm(vec![ReportTransactStatus(QueryResponseInfo { destination, query_id, max_weight, diff --git a/precompiles/assets-erc20/src/mock.rs b/precompiles/assets-erc20/src/mock.rs index e0994b476..acca0eb70 100644 --- a/precompiles/assets-erc20/src/mock.rs +++ b/precompiles/assets-erc20/src/mock.rs @@ -255,7 +255,6 @@ impl pallet_assets::Config for Runtime { type WeightInfo = pallet_assets::weights::SubstrateWeight; type RemoveItemsLimit = frame_support::traits::ConstU32<1000>; type CallbackHandle = (); - #[cfg(feature = "runtime-benchmarks")] type BenchmarkHelper = (); } diff --git a/runtime/heiko/src/lib.rs b/runtime/heiko/src/lib.rs index a845e18cf..6bb64e9e6 100644 --- a/runtime/heiko/src/lib.rs +++ b/runtime/heiko/src/lib.rs @@ -183,7 +183,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { spec_version: 204, impl_version: 33, apis: RUNTIME_API_VERSIONS, - transaction_version: 17, + transaction_version: 18, state_version: 0, }; diff --git a/runtime/kerria/src/lib.rs b/runtime/kerria/src/lib.rs index 303f075f8..21902bdf0 100644 --- a/runtime/kerria/src/lib.rs +++ b/runtime/kerria/src/lib.rs @@ -183,7 +183,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { spec_version: 204, impl_version: 33, apis: RUNTIME_API_VERSIONS, - transaction_version: 17, + transaction_version: 18, state_version: 0, }; diff --git a/runtime/parallel/src/lib.rs b/runtime/parallel/src/lib.rs index a224fa36c..88cec8846 100644 --- a/runtime/parallel/src/lib.rs +++ b/runtime/parallel/src/lib.rs @@ -187,7 +187,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { spec_version: 204, impl_version: 33, apis: RUNTIME_API_VERSIONS, - transaction_version: 17, + transaction_version: 18, state_version: 0, }; diff --git a/runtime/vanilla/src/lib.rs b/runtime/vanilla/src/lib.rs index 6c0f13c8f..72474e272 100644 --- a/runtime/vanilla/src/lib.rs +++ b/runtime/vanilla/src/lib.rs @@ -183,7 +183,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { spec_version: 204, impl_version: 33, apis: RUNTIME_API_VERSIONS, - transaction_version: 17, + transaction_version: 18, state_version: 0, };