Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance "Downloading file to port..." message #29

Open
PropGit opened this issue Mar 22, 2017 · 8 comments
Open

Enhance "Downloading file to port..." message #29

PropGit opened this issue Mar 22, 2017 · 8 comments

Comments

@PropGit
Copy link
Contributor

PropGit commented Mar 22, 2017

For Wi-Fi downloads, enhance "Downloading file to port..." message from this form:
Downloading file to port <ip_address>
to this form:
Downloading file to port <module_name> (<ip_address>)

This will make more sense to the user when they are using a GUI dev system where they selected the port by module_name, yet the console message stream only shows the ip_address (which they didn't know before then).

@dbetz
Copy link
Collaborator

dbetz commented Mar 22, 2017

This isn't really possible because proploader doesn't know the module names unless it performs a discovery operation. This would require every load attempt to first do discovery.

@dbetz
Copy link
Collaborator

dbetz commented Mar 22, 2017

Well, I take that back. If I have the IP address I can ask the module for its name. Is that what you want?

@PropGit
Copy link
Contributor Author

PropGit commented Mar 22, 2017

Sorry, I forgot about that.

Querying the IP address for the module name would certainly work.

Yes, that would be great.

@PropGit
Copy link
Contributor Author

PropGit commented Mar 22, 2017

If the query process did not succeed, please make sure the final outputs (error messages) include the IP address that was attempted. The above change causes the Downloading message to occur at a different time in the actual process, I believe, and we don't want the target IP address knowledge failing to be reflected in PropLoader's output in those rare cases.

@dbetz
Copy link
Collaborator

dbetz commented Mar 22, 2017

Your request suggests displaying both the IP address and the module name. If for some reason I can't get the module name or it's blank I can just display the IP address. Should it still be in parens though?

@PropGit
Copy link
Contributor Author

PropGit commented Mar 22, 2017

In that case (an error, i.e.: can not reach IP address) the IP address can be without parens.

@dbetz
Copy link
Collaborator

dbetz commented Mar 22, 2017

ok

@PropGit PropGit added this to the April Release v1.3 milestone Mar 28, 2017
@PropGit
Copy link
Contributor Author

PropGit commented Mar 31, 2017

This has been deferred until later and may be removed at that time.

@PropGit PropGit removed this from the April Release v1.3 milestone Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants