Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review WX protocol implmentation #84

Open
PropGit opened this issue Oct 9, 2019 · 1 comment
Open

Review WX protocol implmentation #84

PropGit opened this issue Oct 9, 2019 · 1 comment
Assignees
@PropGit

Comments

@PropGit
Copy link
Contributor

PropGit commented Oct 9, 2019

I'm concerned that the last setTimeout() in discoverWirelessPorts() is allowing for a bug; perhaps the sometimes-disappearing WiFi Module behavior. Review this code and debug well to determine if and why that setTimeout() is needed.
@PropGit PropGit self-assigned this Oct 9, 2019
@PropGit
Copy link
Contributor Author

PropGit commented Oct 9, 2019

Also, consider the case where the last response packet arrives after AllowWX is unchecked... does disc_packet get reset properly upon the start of the next discover operation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PropGit PropGit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PropGit