Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider whether or not CORS is the right long-term solution for allowed-origin security #54

Open
PropGit opened this issue Aug 19, 2018 · 3 comments
Assignees
Labels

Comments

@PropGit
Copy link
Contributor

PropGit commented Aug 19, 2018

Manually-implemented HTTP over TCP gets around allowed-origin security in Chrome Apps- but will it do so always?

Consider this and whether or not to implement CORS in Parallax-ESP (which should be simple, but may require it be open to all, creating more attack vectors).

Current thoughts are not to expose this, but to stick with the TCP solution.

@PropGit PropGit self-assigned this Aug 19, 2018
@pjewald
Copy link
Contributor

pjewald commented Sep 18, 2019

We are using CORS in the Solo project to communicate with the BlocklyProp Client installed locally. This was required because the browser is initially communicating with solo.parallax.com. It then fails when the scripts obtained from solo.parallax.com attempt to communicate with the BlocklyProp Client HTTP interface located at localhost. The browser correctly identifies that solo.parallax.com and localhost are different domains.

I am concerned that the current HTTP implementation may not be properly handling this properly or at all.

@PropGit
Copy link
Contributor Author

PropGit commented Sep 18, 2019

Can you describe exactly where this fails? I've never had problems with BlocklyProp Client and solo.parallax.com and just tested it again; no connection errors and downloads to Propeller are working fine for me.

@pjewald
Copy link
Contributor

pjewald commented Sep 18, 2019

I would see the CORS errors in the browser debug console. I do not remember if anything actually broke - it's been a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants