feat: integrate EngineArgs into NodeCommand #13748
Conversation
|
Hi @mattsse , I have a question. The values |
htiennv
requested review from
mattsse,
Rjected,
onbjerg and
klkvr
as code owners
|
we can move this constants to node-core |
| let engine_tree_config = TreeConfig::default() | ||
| .with_persistence_threshold(builder.config.engine.persistence_threshold) | ||
| .with_memory_block_buffer_target(builder.config.engine.memory_block_buffer_target) | ||
| .with_state_root_task(builder.config.engine.state_root_task_enabled); |
There was a problem hiding this comment.
we can probably make this a function of builder or config?
There was a problem hiding this comment.
Yes, specifically it'd be nice if in the Optimism config we could instantiate TreeConfig from RollupArgs somehow, so that we don't need this: https://github.com/paradigmxyz/reth/blob/main/crates/optimism/bin/src/main.rs#L26-L41
Ideally this https://github.com/paradigmxyz/reth/blob/main/crates/optimism/bin/src/main.rs#L26C12-L39 becomes builder.node(OpNode::new(rollup_args))
Closes #13742.