-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use full qualified reth_codecs:: path + syntax when deriving reth_codecs::Compact #11862
Comments
Can I take this one? |
if you're not able to work on this @aroralanuk, let me know, would love to work on this |
Hey @AlbionaHoti, give me 1 more day. Otherwise, I'll unassign myself and ping you here. |
@AlbionaHoti Hey, I have a hectic week ahead, so I won't be able to close this one. I'm unassigned myself if you wanna give it a go. Feel free to look at my wip PR. |
cool, ty! |
Can I try solving this issue? Background: My Proposed Solution ToTackle The Issue:
|
hey @AlbionaHoti do you still want to work on this? |
Can i be assigned this |
Describe the feature
currently we expect that Compact trait is in scope:
reth/crates/storage/codecs/derive/src/compact/generator.rs
Lines 34 to 36 in bc43613
hence we have a bunch of these:
reth/crates/primitives/src/receipt.rs
Lines 13 to 14 in bc43613
we can get rid of this by using the fully qualified path and syntax in the code we generate.
we also need a new attribute so that we can use this in the reth_codes crate itself, e.g.:
reth/crates/storage/codecs/src/alloy/transaction/legacy.rs
Lines 6 to 9 in bc43613
this should be similar to serde crate attribute
https://serde.rs/container-attrs.html#crate
so that we can use in the quote!
This task is done if we can remove all feature gated
use reth_codecs::Compact
imports#11863 has some wip and can be taken over
Additional context
No response
The text was updated successfully, but these errors were encountered: