Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-line quotes break on conversion after split #34

Open
hcayless opened this issue Feb 23, 2022 · 0 comments
Open

Multi-line quotes break on conversion after split #34

hcayless opened this issue Feb 23, 2022 · 0 comments
Assignees
Labels
java Pull requests that update Java code Leiden+

Comments

@hcayless
Copy link
Member

If a <q> happens to span lines and the splitting process splits inside the quote, then Leiden+ conversion breaks. This may be a tough one to solve for the splitter, given that there's no way to tell a start quote from an end quote other than counting, and split chunks aren't aware of each other. It might be far easier to use "smart" quotes (“”) instead, because they balance properly, maybe even Guillemets («») in addition.

It's probably possible to work around this if smart quotes are undesirable, but tricky....

@hcayless hcayless self-assigned this Feb 23, 2022
@hcayless hcayless added java Pull requests that update Java code Leiden+ labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code Leiden+
Projects
None yet
Development

No branches or pull requests

1 participant