Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make data parameter in Model constructors typed #37

Open
andrenarchy opened this issue Sep 7, 2017 · 0 comments
Open

Make data parameter in Model constructors typed #37

andrenarchy opened this issue Sep 7, 2017 · 0 comments

Comments

@andrenarchy
Copy link
Member

andrenarchy commented Sep 7, 2017

We lose the type safety on the data parameter in model constructors if the derived class does not implement a constructor à la

class Person extends Model {
  constructor(data?: Partial<Person>) {
    super(data);
  }
}

Try to make the data parameter typed! Waiting for microsoft/TypeScript#5863.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant