Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential improvements to identifying customers by external_id (WIP) #523

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

reichert621
Copy link
Collaborator

Description

WIP

(TODO: write down thoughts on how we could improve this further)

Some things to keep in mind:

  • We'll need to make sure this works in both the chat widget and the Storytime library
    • (Starting to think that it might be worth considering bundling these together somehow)
  • How do we avoid duplicate customers with the same email/external_id? Is this a problem or not? (Seems like it would be a problem, but maybe it's ok across different domains?)
  • Should we change how we cache customer info?

Issue

#515

Checklist

  • Everything passes when running mix test
  • Ran mix format
  • No frontend compilation warnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant