Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

head_job.err as ansi result #9

Open
jsmedmar opened this issue Jan 8, 2021 · 1 comment
Open

head_job.err as ansi result #9

jsmedmar opened this issue Jan 8, 2021 · 1 comment

Comments

@jsmedmar
Copy link
Contributor

jsmedmar commented Jan 8, 2021

Should we update the type of head_job.err to ansi? isabl_cli/app.py#L131

In favor of In favor of the web https://github.com/isabl-io/web/pull/74

@jsmedmar
Copy link
Contributor Author

jsmedmar commented Jan 8, 2021

A few thoughts here:

  • We should set both head_job.err and head_job.log to ansi by default in the frontend directly. This will ensure backwards compatibility.
  • If you want to get ansi logs, you have to run head_job.sh with unbuffer. At this point both stdout and stderr get combined and it doesn't make sense anymore to keep head_job.err, but just something like Analysis Logs. So we may want to add a setting that enables the user to hide the head_job.err chip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant