Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing analyses, targets, experiments from AnalysisSerializer for performance #10

Open
jsmedmar opened this issue Jan 8, 2021 · 3 comments

Comments

@jsmedmar
Copy link
Contributor

jsmedmar commented Jan 8, 2021

Are there any negative side effects to removing analyses, targets, experiments from AnalysisSerializer in isabl_api/serializers.py?

We would like to do that to speed up the Isabl API. I thought this would have an impact on filtering via isabl cli, but filtering seems to be working just fine.

@jsmedmar
Copy link
Contributor Author

jsmedmar commented Jan 8, 2021

where are you having performance issues? you can remove them from your query using fields!=analyses,targets,references

If you remove them altogether, then the Isabl CLI logic to determine unique analyses will stop working

@jsmedmar
Copy link
Contributor Author

jsmedmar commented Jan 8, 2021

"...then the Isabl CLI logic to determine unique analyses will stop working"

Can you point me to code where removing them could influence the logic to determine unique analyses?

@jsmedmar
Copy link
Contributor Author

jsmedmar commented Jan 8, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant