Percent decode the list files when parsing response #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 90.23% 90.31% +0.07%
==========================================
Files 29 29
Lines 1372 1383 +11
==========================================
+ Hits 1238 1249 +11
Misses 134 134
|
| // #[serde(rename = "EncodingType")] | ||
| // encoding_type: String, | ||
| #[serde(rename = "EncodingType")] | ||
| encoding_type: String, |
There was a problem hiding this comment.
I'm wandering whether this should be an enum or not
There was a problem hiding this comment.
Like an Option<String>?
Since there is an official S3 specification, as far as I know, I have no idea.
What I can say is that DO, minio, and was all return the encoding_type set to url. But maybe some other providers don't.
I would say we keep it like that until someone gives us an implementation that doesn't work like that personally 😅
Kerollmops
reviewed
Oct 17, 2023
|
Hey, sorry I was on vacation last week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, while trying out the
ListObjectsV2::parse_responsecommand I noticed that we were not percent decoding the keys as documented here: https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjectsV2.html#API_ListObjectsV2_RequestSyntaxI had no issue with
minioas I don't use any strange characters. But the Digital Ocean S3 implementation does percent-encode the/character, which completely broke my code.I updated my lib, but I think it should be handled by rusty_s3 directly, personally 🤔
What do you think?