Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminus self:plugin:install does not exit with an error if the composer command failed #2497

Open
davereid opened this issue Sep 18, 2023 · 0 comments

Comments

@davereid
Copy link
Contributor

Platform

( ) MacOS
(x) Linux via GitHub Action runner
( ) WSL2

Installed Via

( ) Homebrew
( ) Apt Package
(x) Manually via Composer

PHP Version

( ) 7.4x
( ) 8.0
(x) 8.1

Terminus Version

3.2.1

Command Executed

Run terminus self:plugin:install terminus-build-tools-plugin
  terminus self:plugin:install terminus-build-tools-plugin
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    PANTHEON_MACHINE_TOKEN: ***
    DDEV_GITHUB_TOKEN: ***
    PANTHEON_ENV: dev
    COMPOSER_PROCESS_TIMEOUT: 0
    COMPOSER_NO_INTERACTION: 1
    COMPOSER_NO_AUDIT: 1
    COMPOSER_AUTH: {"github-oauth": {"github.com": "***"}}
Error: ]  Failed executing "composer search -d /home/runner/.terminus/terminus-dependencies-[2](https://github.com/principaldrupal-emu/wsk-storefront/actions/runs/6225114922/job/16894827209#step:15:2)7a446d99[3](https://github.com/principaldrupal-emu/wsk-storefront/actions/runs/6225114922/job/16894827209#step:15:3) -N -t terminus-plugin --format json pantheon-systems/terminus-build-tools-plugin": 
In CurlDownloader.php line 372:
                                                                               
  curl error [5](https://github.com/principaldrupal-emu/wsk-storefront/actions/runs/6225114922/job/16894827209#step:15:5)[6](https://github.com/principaldrupal-emu/wsk-storefront/actions/runs/6225114922/job/16894827209#step:15:6) while downloading https://packagist.org/packages/list.json: O  
  penSSL SSL_read: error:0A000[12](https://github.com/principaldrupal-emu/wsk-storefront/actions/runs/6225114922/job/16894827209#step:15:12)6:SSL routines::unexpected eof while reading,  
   errno 0                                                                     
                                                                               

search [-N|--only-name] [-O|--only-vendor] [-t|--type TYPE] [-f|--format FORMAT] [--] <tokens>...

 
Error: ]  pantheon-systems/terminus-build-tools-plugin is not a valid Packagist project.

Expected behavior

For the command to have exited with a non-zero exit code in this case.

Actual behavior

The GitHub workflow kept running because a zero exit code (success) was issued when running this command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant