Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarity to WPMS documentation about requesting multisites #9332

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

jazzsequence
Copy link
Contributor

Summary

WordPress Multisite - Add more explanation about why WordPress sites can't just become Multisites on Pantheon (if the upstream is using the wrong framework)

fixes #9252

@jazzsequence jazzsequence requested a review from a team as a code owner November 26, 2024 18:27
@jazzsequence jazzsequence self-assigned this Nov 26, 2024
@jazzsequence jazzsequence added Type: Fix Content Issue or PR to resolve incorrect information in the docs Topic: WordPress WordPress-specific labels Nov 26, 2024
@jazzsequence
Copy link
Contributor Author

@codyfishman Tagged you here to review based on your feedback in #9252

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9332-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Existing WordPress sites cannot be converted to a multisite, however they can be [migrated](/migrate-wordpress-multisite).
Existing WordPress sites on Pantheon cannot be converted to a multisite due to the framework limitation. Instead, if a WordPress Multisite upstream has been created for you, a new site can be created based on that upstream and the codebase pushed to that site repository (since WordPress Multisite is a core component of WordPress and uses the same code).

**Note:** Any non-multisite WordPress site can be [configured](/guides/multisite/config) as a WordPress Multisite. However, it is not recommended to set up your WordPress site to be a Multisite if your upstream is not using the correct framework.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rewrite this sentence to be more like "If you try to changing a WordPress instance on Pantheon to Multisite by only making changes within WordPress without also making this "platform framework" change (that updates nginx and other settings) you will get errors."

Copy link
Contributor

@stevector stevector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As written, the note makes things more confusing.

I am hypothesizing that glossary terms are added based on the <dfn> tag. I am further hypothesizing that if we leave the markdown syntax on this page intact, the new glossary terms would not be added correctly, therefore I have converted all the markdown bullets to html list items.

I have added "framework" on this page because it makes the most sense to be included on a page about upstreams.
@jazzsequence jazzsequence requested a review from a team as a code owner November 27, 2024 21:20
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9332-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9332-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9332-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9332-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: WordPress WordPress-specific Type: Fix Content Issue or PR to resolve incorrect information in the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarifying vanilla WP / WPMS migration steps and language
2 participants