-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clarity to WPMS documentation about requesting multisites #9332
base: main
Are you sure you want to change the base?
Conversation
@codyfishman Tagged you here to review based on your feedback in #9252 |
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9332-documentation.appa.pantheon.site |
Existing WordPress sites cannot be converted to a multisite, however they can be [migrated](/migrate-wordpress-multisite). | ||
Existing WordPress sites on Pantheon cannot be converted to a multisite due to the framework limitation. Instead, if a WordPress Multisite upstream has been created for you, a new site can be created based on that upstream and the codebase pushed to that site repository (since WordPress Multisite is a core component of WordPress and uses the same code). | ||
|
||
**Note:** Any non-multisite WordPress site can be [configured](/guides/multisite/config) as a WordPress Multisite. However, it is not recommended to set up your WordPress site to be a Multisite if your upstream is not using the correct framework. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rewrite this sentence to be more like "If you try to changing a WordPress instance on Pantheon to Multisite by only making changes within WordPress without also making this "platform framework" change (that updates nginx and other settings) you will get errors."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As written, the note makes things more confusing.
I am hypothesizing that glossary terms are added based on the <dfn> tag. I am further hypothesizing that if we leave the markdown syntax on this page intact, the new glossary terms would not be added correctly, therefore I have converted all the markdown bullets to html list items. I have added "framework" on this page because it makes the most sense to be included on a page about upstreams.
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9332-documentation.appa.pantheon.site |
didn't work for the glossary
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9332-documentation.appa.pantheon.site |
more in line with what exists in the dashboard
go back to upstream framework but describe as "site framework" in parenthetical
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9332-documentation.appa.pantheon.site |
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9332-documentation.appa.pantheon.site |
Summary
WordPress Multisite - Add more explanation about why WordPress sites can't just become Multisites on Pantheon (if the upstream is using the wrong framework)
fixes #9252