Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

digiline piston duplication bug #674

Open
BuckarooBanzay opened this issue Jun 24, 2021 · 5 comments
Open

digiline piston duplication bug #674

BuckarooBanzay opened this issue Jun 24, 2021 · 5 comments
Labels
bug 🐛 Something isn't working

Comments

@BuckarooBanzay
Copy link
Contributor

Reported by DakotaVeronica

Reproduction:

  • Place some pistons on top of each other
  • Actuate them with a digiline signal

screenshot_20210624_151146
screenshot_20210624_151150

@BuckarooBanzay BuckarooBanzay added the bug 🐛 Something isn't working label Jun 24, 2021
@BuckarooBanzay
Copy link
Contributor Author

@cheapie ^ (in case you are still using github :D)

@OgelGames
Copy link
Contributor

Interesting... I wonder if that has anything to do with the changes I made to them, or if they were like that before... 🤔

@S-S-X
Copy link
Member

S-S-X commented Jun 24, 2021

If actual cause is known already it might be simpler to fix in mt-mods/digistuff as there's multiple changes not merged to upstream: mt-mods/digistuff/compare/upstream...master

Seems that scheduled merge upstream workflow was disabled because repository been inactive for some time, enabled executed it manually.

edit. seems like no updates but got funny error (workflow succeeded with green checkmark however):

* upstream                        4a3c741 Add "sendpacked" and "loadpacked" commands to GPU These allow converting images to/from string representations that are much easier and faster for Luacontrollers to store and handle.
  remotes/origin/master           126aa82 Add nic format option for json response (#17)
  remotes/origin/nic-url-sanitize 82cf9aa escape all unsafe characters
  remotes/origin/upstream         4a3c741 Add "sendpacked" and "loadpacked" commands to GPU These allow converting images to/from string representations that are much easier and faster for Luacontrollers to store and handle.
  remotes/upstream/master         4a3c741 Add "sendpacked" and "loadpacked" commands to GPU These allow converting images to/from string representations that are much easier and faster for Luacontrollers to store and handle.
hub pull-request   -b master   -h upstream   --no-edit   -m "Pulling upstream into master" -l "upstream"   || true
Error creating pull request: Unprocessable Entity (HTTP 422)
No commits between master and upstream

That Error creating pull request: Unprocessable Entity (HTTP 422), not sure what that actually means there... seems like no updates from upstream however.

@OgelGames
Copy link
Contributor

OgelGames commented Jun 24, 2021

From what I can tell, digiline pistons work exactly the same as mesecon pistons (as I intended for it to be when I made changes to them), yet mesecon pistons don't duplicate, so there must be something else digiline related happening...

@OgelGames
Copy link
Contributor

RGB glass can also be duplicated: (probably some other nodes too)
glass_dupe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants