jumpdrive area protection check bugs

[Klaranth]

Apparently a JD cant bring a ship to jump onto the edge of a protected area.

Please consult Fexor and Huhhila for more information.

[S-S-X]

See https://github.com/minetest-mods/areas/blob/4018c0d20450a106b3bda6627894b130595a7cd6/api.lua#L126-L134
and https://github.com/mt-mods/jumpdrive/blob/c543e62d46bfcd5154dcb01ba09b1ad4f68923c2/is_area_protected.lua#L6-L20

[FeXoR-o-Illuria]

Yes, the if check in line 160-162 is not sufficient.

My proposal would be to rewrite areas:canInteractInArea to:

• Determine the areas overlapping with the target area
• Segment the target area for each face, edge and corner of those areas inside it (Yea, that's the harder part) and store the owners in a list with each segment and make each subsegment "inherit" those. Early continue for areas of that user and open areas if allow_open.
• Check for each segment if the user is in the segment's owner list (or open andallow_open or owner list empty)

Other ideas welcome ;)

(And why does none of those functions have an optional argument "areas" defaulting to self.areas? :D)

[OgelGames]

eshattow

Area Protect with faction area open set enabled, other faction members cannot use jumpdrive; seems like a bug.

S-S-X

Factions are not compatible with jumpdrive and not really yet ready for wide use that's not only protection problem factions currently have