Skip to content

Development Process

Xiaohan Zhang edited this page Dec 1, 2016 · 8 revisions

Bugfixes / Enhancement Requests

  1. Pull latest develop
  2. Create a branch off of develop, usually named after the ticket (ex: "1791fix1", "1684ER", etc).
  3. Work and commit on branch.
  4. Write tests, and then run all tests with grunt test.
  5. Make sure you commit the built files plottable.js, plottable.d.ts, plottable-npm.d.ts
  6. Push branch to remote.
  7. Create a pull request from your branch into develop.
  8. Assign a developer to review (one of @hellochar, @CalvinFernandez, or @themadcreator).
  9. If you receive a [-1], back to step 3 to address concerns.

Larger Features

  1. Pull latest develop.
  2. Create a feature branch off of develop.
  3. Follow steps 2 through 8 above, but cutting off and merging into your feature branch instead of **develop. Tag any pull requests with the [Side Branch] tag.

Notes on Node and NPM

2015-09-18 We're still looking into this issue, but our setup doesn't appear to work correctly with newer versions of Node. Use v0.12.7 until we can get to the bottom of this.

Commit only on valid builds

Especially useful in going back in history, if builds are stable at every commit, we can safely go to that commit to check for functionality at that point in time.