-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TabsProps has "id" as required, but is not required in component usage #6899
Comments
Actually, it is due to assigning the type of PR to fix: #6900 Still, this would be fixed if all class components get converted to function components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TabsProps
id
prop is required, but somewhere this gets changed to optional:I think this has to do with the usage of
React.PureComponent
inAbstractPureComponent
, it seems this changes all properties to optional, which could lead to major issues.At somepoint, all component
class
es should probably be migrated to functions, per React's reccomendation: https://react.dev/reference/react/PureComponent#alternativesThe text was updated successfully, but these errors were encountered: