Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nodejs asset compilation, similar to rails-assets #671

Open
fgrehm opened this issue Sep 23, 2022 · 2 comments
Open

Support nodejs asset compilation, similar to rails-assets #671

fgrehm opened this issue Sep 23, 2022 · 2 comments

Comments

@fgrehm
Copy link

fgrehm commented Sep 23, 2022

Describe the Enhancement

Support asset compilation with node (ex: with webpacker) for Go apps, without the need to specify one of the nodejs buildpacks

Possible Solution

A new go-assets buildpack that wraps some of the existing nodejs BPs (probably everything except for *-start ones), users can then specify the build CMD with BP_NODE_RUN_SCRIPTS

Motivation

It's possible to achieve this by simply including the full nodejs buildpack in a group alongside the go BP, but it'd be nice to be able to specify a single group for our go apps. One could also argue that there's a potential need for doing this for other languages like java and maybe others

@fg-j
Copy link

fg-j commented Sep 26, 2022

I like this idea. @fgrehm is there a sample application you could provide that demonstrates this Go + nodejs asset compilation use case?

@fgrehm
Copy link
Author

fgrehm commented Sep 26, 2022

is there a sample application you could provide that demonstrates this Go + nodejs asset compilation use case?

Unfortunately nothing public, even internally we only have one app that has this use case (but a very important one 😅 ).

That app has a "hand rolled" stack, but I do hope to play with https://gobuffalo.io at some point this week and can try to report back with more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants