Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Config QOL #594

Open
2 tasks done
Nallieheai opened this issue Nov 15, 2024 · 0 comments · May be fixed by #595
Open
2 tasks done

Dynamic Config QOL #594

Nallieheai opened this issue Nov 15, 2024 · 0 comments · May be fixed by #595
Labels
enhancement Improvement to an already existing notifier

Comments

@Nallieheai
Copy link

Nallieheai commented Nov 15, 2024

Checklist

  • I've searched the issues and pull requests for similar looking suggestions.
  • I've checked the Unreleased section of the changelog for newly added features that sound like my suggestion.

Describe your Suggestion

Hello!

Ive been messing around with the Dynamic Config URL as i was adviced in the last issue i created. It is working great and doing everything we could possbily want, however i have some suggestions to potentially improve it. One issue i have ran into is that when we remove items from the lootItemAllowlist it does not get removed upon a restart of RuneLite for the players that use the config URL.

I went and did some digging in the repo and found this line:
if (webhookConfigKeys.contains(key) || "ignoredNames".equals(key) || "lootItemAllowlist".equals(key) || "lootItemDenylist".equals(key))

  1. Would it be possible to add some checkbox to decide if you would like to override these settings individually?

  2. I understand this might make it more messy under the advanced tab so perhaps it would be good to add a new tab for Dynamic Config URL as a whole, it is a very powerful tool and it would be awesome to have some more configuration for it.

  3. A Reload button to fetch all the data from the Dynamic Config URL again without having to restart RuneLite or manually resetting the settings and then placing the URL in there again, closing the panel and opening it again. (I understand closing and opening the panel is not something we can get around, i think?)

  4. An option to change how often it fetches the config, for example:

  • Upon each login (not world hops)
  • Upon start of RuneLite (current setting?)
  1. If any of these settings seem reasonable and are added, it would be nice to have those added to the config as well so we can set that as a default right away so the user does not have to manually enable some of these settings.

Reasoning

I understand the reasoning why it merges for the ignoredNames, that is not something we have gotten around to using yet, but we would like to take advantage of it in the future so items do not post from people playing multiple accounts if possible. However this could also be solved with a custom webhook handler recommended by iProdigy in my last post.

I added "Bones" to the whitelist of items while testing and then removed it later, but some people ended up getting the updated config, but once the bones had been removed from the config it wouldnt remove it from the people that got that update within the 1-2 hours it was there during development of the Discord Bot. If an opsie happens during a Clan vs Clan bingo with an item, where there are hundreds of participants it would be great to be able to simply update the config and know that it will be gone upon the next restart for all of the users. This is also why it would be good to have a button to fetch all the settings again (though it is hard enough as it is to get people to even use a plugin to begin with)

Hence my suggestion, allow us to completely replace the lootItemAllowlist and lootItemDenylist while leaving the ignoredNames untouched or having it merge as it does now by using checkboxes. Currently these three are the only special cases so if all the settings that has to do with Dynmaic Config URL was placed in its own tab it wouldnt be too messy to have those 3 extra checkboxes i reckon.

The part about having it fetch the new data upon each login would be nice because often before a bingo we will ask all participants to relog to make sure websites such as WiseOldMan, TempleOSRS, etc will update so that XP/boss kc is tracked correctly. This would also allow us to make sure everyone receive the latest version of the config upon logging in just before the event starts w/o having to do anything special.

Thanks for reading!

@Nallieheai Nallieheai added the enhancement Improvement to an already existing notifier label Nov 15, 2024
@iProdigy iProdigy linked a pull request Nov 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an already existing notifier
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant