Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Thrash (Frenzy Moves) Counter Increments despite Move Failing, Paralysis #4277

Open
Snailman11 opened this issue Sep 16, 2024 · 1 comment · May be fixed by #4680
Open

[Bug] Thrash (Frenzy Moves) Counter Increments despite Move Failing, Paralysis #4277

Snailman11 opened this issue Sep 16, 2024 · 1 comment · May be fixed by #4680
Labels
Move Affects a move P2 Bug Minor. Non crashing Incorrect move/ability/interaction

Comments

@Snailman11
Copy link
Collaborator

Snailman11 commented Sep 16, 2024

Describe the bug

-The Frenzy Counter is incremented whenever a Frenzy move is selected and;
affects the target, the user is not hurt by confusion, and the attack passes the accuracy check.

This does not include full paralysis and the move failing due to a missing target. (-I have not checked freeze)
When a Frenzy move is not executed due to full paralysis or if the move fails, the counter is incremented inappropriately.
However, because the Frenzy move was not executed, the user isn't locked into a specific move and can be switched out through the "Pokémon" option in the battle menu.

-The latter excludes the initial offer to switch granted on a new wild encounter, which does not show up because the counter is still active.

-The Pokémon also seems to lose the ability to use the effect of self-targeting moves (I don't know to what extent)

-If the Frenzy move is used again, the counter increments and the user may become confused if that usage would reset the counter. (is the final turn of the Frenzy move)

-Frenzy moves sometimes continue through full paralysis on their second turn if the first one succeeded.
If It would have ended on the second turn, then confusion does not occur until the first turn thrash is selected again.

Link to Discord's Bug report (Thrash Breaking the option to swap out)
https://discord.com/channels/1125469663833370665/1247785975518597191

Session export file

No response

User data export file

No response

Expected behavior

Thrash's counter should properly reset when it isn't used successfully

Screenshots / Videos

Failing

single.1.mp4
double.1.1.mp4

Paralysis

Cant.switch.if.thrash.fails.on.para.mp4

Self-target moves don't "work" when the thrash counter is higher than 0 (fails to raise stats)

Status.moves.dont.work.during.this.period.mp4

What OS did you observe the bug on?

Other

If other please specify

gameplay

Which browser do you use?

Other

If other please specify

gameplay

Additional context

-Frenzy moves sometimes incorrectly continue through full paralysis if used successfully on the first turn. The pokemon is paralyzed on the 2nd turn, and uses it successfully and gets confused on the 3rd.
([Bug] Frenzy moves wont stop by paralyze #3718)

-When used on the last turn and a Frenzy move misses, the user is correctly confused.

@Snailman11 Snailman11 added Move Affects a move P2 Bug Minor. Non crashing Incorrect move/ability/interaction labels Sep 16, 2024
@Snailman11
Copy link
Collaborator Author

Snailman11 commented Sep 16, 2024

Here was an old fix
([Bug] Fixes bug with frenzy moves keeping the confusion counter despite disruption )
#3041

@Snailman11 Snailman11 added Move Affects a move P2 Bug Minor. Non crashing Incorrect move/ability/interaction and removed Move Affects a move P2 Bug Minor. Non crashing Incorrect move/ability/interaction labels Oct 8, 2024
geeilhan added a commit to geeilhan/pokerogueFork that referenced this issue Oct 17, 2024
geeilhan added a commit to geeilhan/pokerogueFork that referenced this issue Oct 17, 2024
@DayKev DayKev linked a pull request Oct 18, 2024 that will close this issue
10 tasks
DayKev pushed a commit to geeilhan/pokerogueFork that referenced this issue Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Move Affects a move P2 Bug Minor. Non crashing Incorrect move/ability/interaction
Projects
Status: In review
Development

Successfully merging a pull request may close this issue.

1 participant