Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Type for charge_remainder_fee in getSplitOptionsResponse Schema #37

Open
renatoastra opened this issue Aug 12, 2024 · 0 comments

Comments

@renatoastra
Copy link

I identified an issue with the getSplitOptionsResponse schema where the property charge_remainder_fee was incorrectly typed as optional(nullable(string)). This was causing errors when interacting with the API, as the correct type should be optional(nullable(boolean)).

Problem

  • Property: charge_remainder_fee
  • Current Type: optional(nullable(string))
  • Expected Type: optional(nullable(boolean))

Steps to Reproduce:

  • Use the SDK to interact with the getSplitOptionsResponse.
  • Note that the charge_remainder_fee is returned or expected as a boolean, causing type errors with the current schema.

Proposed Solution:
I've submitted a pull request that corrects the type to optional(nullable(boolean)), along with adjustments to the related interfaces.

Pull Request Link: #36 - Fix incorrect type for charge_remainder_fee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant