Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pact-cli version on image release #120

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Sep 12, 2023

hopefully fixes #117

with a workflow dispatch on the release image workflow, defaults INCREMENT to "null" - an actual string, with the words null. This will force the version number to remain the same, but increment the 4, portion of the semver, indicating that no changes occurred to the Gemfile, or no features have been incorporated into the Docker image. It just indicates that its been rebuilt and released.

Screenshot 2023-09-12 at 17 24 03

In the scenario that INCREMENT is set, either by

  • release workflow triggered by gem-update (which was triggered by a pact ruby gem repo - see ruby ecosystem )
  • by a user triggering a workflow_dispatch in the UI

The following will occur

  • the next version number will be computed for pact-cli, based on change level in increment
  • the existing release tags will be checked for a match
    • if there is a match the 4th semver will be incremented
  • Docker images are built and pushed. They will also push to latest flag by default, unless toggled by the user in workflow_dispatch
  • on release completion
    • If there are changes in the repo (namely the Gemfile, version.rb and VERSION file) are checked in, committed back, along with the new release tag.
Screenshot 2023-09-12 at 17 23 17

⚠️ if you note in the above image, the multi manifest images are correctly propagated to all tags, in the below image from the latest release from the pactfoundation, its a bit of a mis-mash. I haven't sussed this out yet, as bar the docker destination I am pushing to, the repos are identical 🤷🏾

Screenshot 2023-09-12 at 17 32 39

@YOU54F YOU54F requested a review from bethesque September 12, 2023 16:34
@bethesque
Copy link
Member

The last numeric portion of the version number is really not needed in this package, and we could just get rid of it. The pact-cli only exists as a docker image, and there is no reason to version the gem updates in a separate mechanism to the image or packaging.

@YOU54F YOU54F force-pushed the chore/release_docker_tags branch from c647e6f to 3f7aae2 Compare January 23, 2024 16:13
@YOU54F
Copy link
Member Author

YOU54F commented Jan 23, 2024

Tested this published from test_tag branch and publishing multi manifests with correct tags across all builds so fingers crossed it should all go swimmingly at proper release time (and then I'll delete the test project pictured below)

Screenshot 2024-01-23 at 16 14 43

@YOU54F YOU54F changed the title chore: update pact-cli verson on image release chore: update pact-cli version on image release Jan 23, 2024
@YOU54F YOU54F merged commit 8f9dc53 into pact-foundation:master Jan 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V1.x Release
2 participants