Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plugindriver version consistent #1822

Merged

Conversation

huehnerlady
Copy link
Contributor

In our project we have the following config:

configurations {
    all {
      resolutionStrategy {
        failOnVersionConflict()
        force(dependencyVersions)
      }
    }
  }

With that we see that with the update to pact 4.6.14 there is a new version conflict of the plugin driver

Looking in the project I can see, that there is io.pact.plugin.driver:core:0.5.1 and io.pact.plugin.driver:core:0.4.2 defined, depending if you use api or implementation.

I aligned the version now. In our projects we have either reminder comments or we have variables.
I here thought the least intrusive way is a comment to hopefully remind people to update the version in 2 places in future.

@huehnerlady huehnerlady marked this pull request as ready for review August 28, 2024 07:55
@rholshausen
Copy link
Contributor

Oops! Thank for the PR!

@rholshausen rholshausen merged commit 7a28b1e into pact-foundation:master Aug 28, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants