-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GraphQL to V3 and V4 types #1093
Comments
My view is that adding it in is a strict improvement, as it makes the Pact-JS API consistent - where there's no difference between the V2 and V3/4 feature set. My longer-term view is: for feature-parity with other languages, either neither graphql function should be in pact-js, OR the graphql wrapper should be in all the languages. |
Gist of how to do this here: https://gist.github.com/wabrit/2d1e1f9520aa133908f0a3716338e5ff |
Is this still on the roadmap? |
It's just sugar on top of the HTTP API, so you don't need the graphql interface to achieve GraphQL Testing. We would happily accept a PR though. This being said, it's generally safe to use the pre-V3 interface in this scenario. |
This issue has been linked to a Canny post: V3 support for GraphQL interactions 🎉 |
See pact-foundation/roadmap#94 for a feature request to build a native GraphQL plugin using the pact plugin framework, which would be probably be the preferred approach as it would allow other pact libraries to benefit, rather than the syntactic sugar that the graphql interface pact-js provided |
See https://pact.canny.io/feature-requests/p/v3-support-for-graphql-interactions, and for some code snippets that could be pulled into the change.
Given how simple the code is (wrapper for the interaction type), I'm currently wary of adding it into the core code base and would like to consider the implications of doing so over a little further.
The text was updated successfully, but these errors were encountered: