Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation section of README.md is the wrong path #405

Closed
Martih87 opened this issue Apr 16, 2024 · 2 comments
Closed

Installation section of README.md is the wrong path #405

Martih87 opened this issue Apr 16, 2024 · 2 comments

Comments

@Martih87
Copy link

Software versions

  • OS: e.g. Mac OSX 10.11.5
  • Consumer Pact library: e.g. Pact go v0.0.8
  • Provider Pact library: e.g. pact-jvm-provider-maven_2.11 v 3.3.8
  • Golang Version: go version
  • Golang environment: Provide output of go env

Expected behaviour

go get or go install pact-go is suppose to work with a specific version for v2.

Actual behaviour

Currently, it is unable to install a specific version in version 2.

Steps to reproduce

run the go get command on a fresh system.

Relevent log files

go: github.com/pact-foundation/pact-go/[email protected]: invalid version: unknown revision 2.0.4

fix:

# install pact-go as a dev dependency
go get github.com/pact-foundation/pact-go/[email protected]
# install pact-go as a dev dependency with go install:
go install github.com/pact-foundation/pact-go/[email protected]

# NOTE: If using Go 1.19 or later, you need to run go install instead 
# go install github.com/pact-foundation/pact-go/[email protected]

# download and install the required libraries. The pact-go will be installed into $GOPATH/bin, which is $HOME/go/bin by default. 
pact-go -l DEBUG install 

# 🚀 now write some tests!
@mefellows
Copy link
Member

Thanks, I've updated it now (removed the specific version identifier as it's not needed)

@YOU54F
Copy link
Member

YOU54F commented Sep 4, 2024

Just testing this without the version identifier and it appears to be picking up an older version of the installer prior to this change

https://github.com/pact-foundation/pact-workshop-go/actions/runs/10705576453/job/29681284997#step:4:8

go install github.com/pact-foundation/pact-go/v2
go: downloading github.com/pact-foundation/pact-go/v2 v2.0.8
go: downloading github.com/hashicorp/logutils v1.0.0
Error: ../../../go/pkg/mod/github.com/pact-foundation/pact-go/[email protected]/installer/installer.go:19:2: missing go.sum entry for module providing package github.com/hashicorp/go-version (imported by github.com/pact-foundation/pact-go/v2/installer); to add:
	go get github.com/pact-foundation/pact-go/v2/[email protected]
Error: ../../../go/pkg/mod/github.com/pact-foundation/pact-go/[email protected]/installer/installer.go:24:2: missing go.sum entry for module providing package github.com/spf13/afero (imported by github.com/pact-foundation/pact-go/v2/installer); to add:
	go get github.com/pact-foundation/pact-go/v2/[email protected]
Error: ../../../go/pkg/mod/github.com/pact-foundation/pact-go/[email protected]/installer/installer.go:20:2: missing go.sum entry for module providing package gopkg.in/yaml.v2 (imported by github.com/pact-foundation/pact-go/v2/installer); to add:
	go get github.com/pact-foundation/pact-go/v2/[email protected]
Error: ../../../go/pkg/mod/github.com/pact-foundation/pact-go/[email protected]/command/check.go:9:2: missing go.sum entry for module providing package github.com/spf13/cobra (imported by github.com/pact-foundation/pact-go/v2/command); to add:
	go get github.com/pact-foundation/pact-go/v2/[email protected]
make: *** [Makefile:1[5](https://github.com/pact-foundation/pact-workshop-go/actions/runs/10705576453/job/29681284997#step:4:6): install] Error 1

Resolved by scoping installer to v2.0.8 - change

https://github.com/pact-foundation/pact-workshop-go/actions/runs/10705723646/job/29681775206#step:4:5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants