Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated triggering of Koji builds for comment commands #2565

Closed
lbarcziova opened this issue Oct 4, 2024 · 0 comments · Fixed by #2587
Closed

Duplicated triggering of Koji builds for comment commands #2565

lbarcziova opened this issue Oct 4, 2024 · 0 comments · Fixed by #2587
Assignees
@nforro
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/bug Something isn't working.

Comments

@lbarcziova
Copy link
Member

Example: https://src.fedoraproject.org/rpms/packit/pull-request/1301#comment-223227

This comment triggered the koji_build job twice (hence the followup 2 comments). With @nforro we suspect that this is caused by trigger: commit | koji_build in our koji_build job configuration (here).
@lbarcziova lbarcziova added the area/fedora Related to Fedora ecosystem label Oct 4, 2024
@lbarcziova lbarcziova added the kind/bug Something isn't working. label Oct 4, 2024
@nforro nforro added complexity/single-task Regular task, should be done within days. impact/low This issue impacts only a few users. gain/low This doesn't bring that much value to users. labels Oct 7, 2024
@nforro nforro moved this from new to backlog in Packit Kanban Board Oct 7, 2024
@nforro nforro moved this from backlog to priority-backlog in Packit Kanban Board Oct 7, 2024
@lachmanfrantisek lachmanfrantisek moved this from priority-backlog to refined in Packit Kanban Board Oct 10, 2024
@nforro nforro self-assigned this Oct 16, 2024
@nforro nforro moved this from refined to in-progress in Packit Kanban Board Oct 16, 2024
@nforro nforro mentioned this issue Oct 17, 2024
Merged
@nforro nforro moved this from in-progress to in-review in Packit Kanban Board Oct 17, 2024
@github-project-automation github-project-automation bot moved this from in-review to done in Packit Kanban Board Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nforro nforro

Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/bug Something isn't working.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deduplicate koji_build jobs when doing explicit matching nforro/packit-service
2 participants
@nforro @lbarcziova