Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retriggering propose-downstream seems to ignore configured fast_forward_merge_into branches #2551

Closed
nforro opened this issue Sep 30, 2024 · 1 comment · Fixed by #2564
Closed

Retriggering propose-downstream seems to ignore configured fast_forward_merge_into branches #2551

nforro opened this issue Sep 30, 2024 · 1 comment · Fixed by #2564
Assignees
@majamassarini
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/bug Something isn't working.

Comments

@nforro
Copy link
Member

nforro commented Sep 30, 2024

I have retriggered a failed propose-downstream job of specfile using the Re-Run button on GitHub and the new job finished successfully, however it only updated the already existing (from previous run) rawhide PR and didn't create/update PRs for fast_forward_merge_into branches.
That being said, I have also triggered pull-from-upstream (that for some reason hadn't been triggered automatically) using a comment in an open rawhide PR and the job finished successfully and opened PRs for rawhide and also all configured fast_forward_merge_into branches.
@majamassarini
Copy link
Member

Probably, this is the wrong code
In case of fast forward branches we should not skip them.

@lbarcziova lbarcziova added kind/bug Something isn't working. area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. impact/low This issue impacts only a few users. gain/high This brings a lot of value to (not strictly a lot of) users. labels Oct 1, 2024
@lbarcziova lbarcziova moved this from new to priority-backlog in Packit Kanban Board Oct 1, 2024
@lbarcziova lbarcziova moved this from priority-backlog to refined in Packit Kanban Board Oct 3, 2024
@majamassarini majamassarini self-assigned this Oct 4, 2024
@majamassarini majamassarini moved this from refined to in-progress in Packit Kanban Board Oct 4, 2024
@majamassarini majamassarini mentioned this issue Oct 4, 2024
Merged
@majamassarini majamassarini moved this from in-progress to in-review in Packit Kanban Board Oct 4, 2024
@github-project-automation github-project-automation bot moved this from in-review to done in Packit Kanban Board Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@majamassarini majamassarini

Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/bug Something isn't working.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not filter out branches to fast forward majamassarini/packit-service
3 participants
@majamassarini @nforro @lbarcziova