Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge conflict on fedora downstream version update for qm rpm #2257

Closed
1 of 2 tasks
lsm5 opened this issue Nov 27, 2023 · 6 comments
Closed
1 of 2 tasks

Merge conflict on fedora downstream version update for qm rpm #2257

lsm5 opened this issue Nov 27, 2023 · 6 comments
Assignees
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/bug Something isn't working.

Comments

@lsm5
Copy link

lsm5 commented Nov 27, 2023

What happened? What is the problem?

i see a strange issue with packit updates on the qm package . The PRs in there are having a merge conflict with trying to bump versions from 0.5.7 to 0.6.0 when packit had already done a prior PR bump from 0.5.7 to 0.5.8

What did you expect to happen?

should not have had merge conflicts and should have correctly bumped from 0.5.8 to 0.6.0.

Example URL(s)

No response

Steps to reproduce

No response

What is the impacted category (job)?

Fedora release automation

Workaround

  • There is an existing workaround that can be used until this issue is fixed.

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)
@lsm5
Copy link
Author

lsm5 commented Nov 27, 2023

cc @dougsland

@lbarcziova
Copy link
Member

hi @lsm5 ! Thanks for reporting, from the first look this really doesn't look right. We need to investigate this more, I will have a look into our logs.

@lbarcziova lbarcziova added area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. impact/low This issue impacts only a few users. gain/high This brings a lot of value to (not strictly a lot of) users. labels Nov 28, 2023
@majamassarini majamassarini moved this from new to ready-to-refine in Packit Kanban Board Nov 28, 2023
@lbarcziova
Copy link
Member

We will try to prioritise this issue since this should definitely not happen. From looking into the logs and the code, this is really strange as we always fetch the latest changes from the dist-git repo.

@lachmanfrantisek lachmanfrantisek moved this from ready-to-refine to refined in Packit Kanban Board Dec 7, 2023
@majamassarini majamassarini self-assigned this Dec 21, 2023
@majamassarini majamassarini moved this from refined to in-progress in Packit Kanban Board Dec 21, 2023
@majamassarini
Copy link
Member

I have analyzed the open/merge branch history and found out that the 0.5.8 related branch was merged after the creation of the 0.6.0 related branch.
After we create a branch we do not automatically update/rebase it and for this reason it went out of sync
I think this work already scheduled could probably prevent this to happen again, what do you think @lbarcziova and @lachmanfrantisek?

branch for release action time
f38 0.5.8 opened 2023-11-01 13:40:52
merged 2023-11-05 13:06:35
0.5.9 opened 2023-11-03 20:01:47
  0.6.0 opened 2023-11-05 13:02:08
f39 0.5.8 opened 2023-11-01 13:40:27
merged 2023-11-05 13:06:11
0.5.9 opened 2023-11-03 20:00:40
  0.6.0 opened 2023-11-05 13:01:47
rawhide 0.5.8 opened 2023-11-01 13:40:04
merged 2023-11-05 13:04:01
0.5.9 opened 2023-11-03 20:00:01
  0.6.0 opened 2023-11-05 13:01:28

@majamassarini majamassarini moved this from in-progress to in-review in Packit Kanban Board Jan 8, 2024
@lbarcziova
Copy link
Member

@majamassarini good catch! Yes, I think packit/packit#2182 should prevent this from happening.

@majamassarini
Copy link
Member

I close this one and start to work on packit/packit#2182

@github-project-automation github-project-automation bot moved this from in-review to done in Packit Kanban Board Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/bug Something isn't working.
Projects
Archived in project
Development

No branches or pull requests

3 participants