Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid logs URL stored for Koji builds #2243

Closed
lbarcziova opened this issue Nov 2, 2023 · 0 comments · Fixed by #2244
Closed

Invalid logs URL stored for Koji builds #2243

lbarcziova opened this issue Nov 2, 2023 · 0 comments · Fixed by #2244
Assignees
@lbarcziova
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/bug Something isn't working.

Comments

@lbarcziova
Copy link
Member

When constructing the Koji build logs URL that we store in the DB, we just use the task ID of the main task (not the subtasks) which leads to storing (and then exposing via API) an invalid URL.

Example
@lbarcziova lbarcziova added kind/bug Something isn't working. area/fedora Related to Fedora ecosystem labels Nov 2, 2023
@lbarcziova lbarcziova self-assigned this Nov 2, 2023
@lbarcziova lbarcziova moved this from new to in-progress in Packit Kanban Board Nov 2, 2023
@lbarcziova lbarcziova added complexity/single-task Regular task, should be done within days. impact/low This issue impacts only a few users. gain/low This doesn't bring that much value to users. labels Nov 2, 2023
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Nov 3, 2023
@lbarcziova
Adjust Koji event and model and related methods
feb2df0 
These changes are needed for better integration of the implementation
of storing downstream Koji builds in the DB.
Rename build_id to task_id attribute and related methods and make its usage consistent.
Introduce dict attribute of the event rpm_build_task_ids that is a dict of {arch: id}.
Also adjust the method constructing the logs URL to utilise this dictionary.

Fixes packit#2243
Related to packit#1889
@lbarcziova lbarcziova mentioned this issue Nov 3, 2023
Merged
3 tasks
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Nov 3, 2023
@lbarcziova
Adjust Koji event and model and related methods
67f38d5 
These changes are needed for better integration of the implementation
of storing downstream Koji builds in the DB.
Rename build_id to task_id attribute and related methods and make its usage consistent.
Introduce dict attribute of the event rpm_build_task_ids that is a dict of {arch: id}.
Also adjust the method constructing the logs URL to utilise this dictionary.

Fixes packit#2243
Related to packit#1889
@lbarcziova lbarcziova moved this from in-progress to in-review in Packit Kanban Board Nov 3, 2023
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Nov 7, 2023
@lbarcziova
Adjust Koji event and model and related methods
6c97665 
These changes are needed for better integration of the implementation
of storing downstream Koji builds in the DB.
Rename build_id to task_id attribute and related methods and make its usage consistent.
Introduce dict attribute of the event rpm_build_task_ids that is a dict of {arch: id}.
Also adjust the method constructing the logs URL to utilise this dictionary.

Fixes packit#2243
Related to packit#1889
lbarcziova added a commit that referenced this issue Nov 7, 2023
@lbarcziova
Store downstream Koji builds in DB (#2244)
6c0800b 
TODO:

- [x] Openshift tests
- [x] TODO in code
- [ ] followup dashboard PR (the API was changed so this breaks
dashboard)


Fixes #1889 
Fixes #2243 

Merge after packit/packit#2146


---

RELEASE NOTES BEGIN
The downstream Koji builds are now stored in the database as well and
exposed via `/api/koji-builds` endpoint.
RELEASE NOTES END
@github-project-automation github-project-automation bot moved this from in-review to done in Packit Kanban Board Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbarcziova lbarcziova

Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/bug Something isn't working.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Store downstream Koji builds in DB lbarcziova/packit-service
1 participant
@lbarcziova