Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/packit test to trigger build when the last build is unsuccessful #2219

Closed
lbarcziova opened this issue Oct 9, 2023 · 1 comment · Fixed by #2228
Closed

/packit test to trigger build when the last build is unsuccessful #2219

lbarcziova opened this issue Oct 9, 2023 · 1 comment · Fixed by #2228
Assignees
@lbarcziova
Labels
area/testing-farm Related to Testing Farm integration. area/user-experience Usability issue complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/bug Something isn't working.

Comments

@lbarcziova
Copy link
Member

@psss brought this up on Slack: the builds are currently triggered only if there were no previous attempts to create builds. If the build failed, nothing happens. Better UX would be that the builds would be triggered in that case as well.

Here is the related code.
@lbarcziova lbarcziova added kind/bug Something isn't working. area/user-experience Usability issue area/testing-farm Related to Testing Farm integration. complexity/single-task Regular task, should be done within days. impact/low This issue impacts only a few users. gain/low This doesn't bring that much value to users. labels Oct 9, 2023
@nforro nforro moved this from new to backlog in Packit Kanban Board Oct 9, 2023
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Oct 13, 2023
@lbarcziova
Make /packit test trigger build if the last was not successful
422ed5f 
Fixes packit#2219
@lbarcziova lbarcziova self-assigned this Oct 13, 2023
@lbarcziova lbarcziova moved this from backlog to in-progress in Packit Kanban Board Oct 13, 2023
@lbarcziova lbarcziova mentioned this issue Oct 13, 2023
Merged
softwarefactory-project-zuul bot added a commit that referenced this issue Oct 16, 2023
@softwarefactory-project-zuul
Make /packit test trigger build if the last was not successful (#2228)
6423748 
Make /packit test trigger build if the last was not successful

Fixes #2219

RELEASE NOTES BEGIN
Packit now triggers the build for the /packit test comment command if the last build was not successful.
RELEASE NOTES END

Reviewed-by: František Lachman <[email protected]>
@github-project-automation github-project-automation bot moved this from in-progress to done in Packit Kanban Board Oct 16, 2023
@psss
Copy link
Contributor

psss commented Oct 17, 2023

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbarcziova lbarcziova

Labels
area/testing-farm Related to Testing Farm integration. area/user-experience Usability issue complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/bug Something isn't working.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make /packit test trigger build if the last was not successful lbarcziova/packit-service
2 participants
@psss @lbarcziova