-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ux: merge downstream without triggering build #2186
Comments
Hi @LecrisUT, what about using labels for that? (E.g.
Good point, one can still recreate the PR. |
Also, this should probably skip the build also if |
Labels should be fine. It might be tricky if not all maintainers have the write privilege to the PR labels, but that's an organization issue for the package.
That would be tricky with |
But we can start with the label and see how this works. Will you take a look at that, Cristian? It won't be hard I hope. I can give you some pointers if you want, but you are quite familiar with the codebase as far as I know..;-) |
I think I could navigate this issue. Probably will go through |
Yes, it should be in packit-service/packit_service/worker/handlers/distgit.py Lines 579 to 581 in 9f79483
|
@LecrisUT just a gentle ping. Are you still interested in taking a look into this? (There is a related issue packit/packit#1918 so I would like to know have we stand with this..) |
When thinking about this again, we can:
|
Yeah, I think labels will be easier to manage, I'll take a look this coming week. Thanks for the reminder.
Should be fine because this should be checked when merging the PR.
Yeah, I can see how triggering build with label can be useful. I don't think it can address packit/packit#1918 because the labels can only be on PRs, and you cannot make an empty commit PR in Pagure. I guess this can be partially resolved if we support non-empty PRs |
Some quick notes and questions looking at the implementation:
|
hi @LecrisUT !
pre_check runs each time we create a handler (=> match event to some tasks that need to be run based on the configuration), see this
Not sure about this one, maybe you can explain the problem more, I would say with the right order of the checks we could make it work.
yes, that's right, the
|
As I work on #2269, I will probably cover the labels implementation for this issue as well. |
Conditions on PR labels TODO: docs Fixes #2269 #2186 RELEASE NOTES BEGIN We have introduced new configuration options require.label.present and require.label.absent. By configuring these you can specify labels that need to be present or absent on a pull request for Packit to react on such PR. RELEASE NOTES END Reviewed-by: František Lachman <[email protected]>
Description
There should be some mechanism to merge a packit PR (with
koji_build
job enabled) without triggering a koji build and/or use a new/specific tag. This is particularly important on rawhide where otherwise the builds need to be untagged to fix potential dependency issues.Benefit
No response
Importance
Medium. The packager can always create a new branch in their fork, but it would be a pain to do so.
What is the impacted category (job)?
Fedora release automation
Workaround
Participation
The text was updated successfully, but these errors were encountered: