From e82c0ec6afc592fb45e9a4e2f1119099ce6da970 Mon Sep 17 00:00:00 2001 From: Rebecca Fair Date: Wed, 8 Sep 2021 14:17:25 +0100 Subject: [PATCH] Remove test that optimise-dipole-parameter returns 0.75 On different systems the optimum may be different, and to get a consistent answer the number of q-points should be fairly high, which has high overhead. Better not to test a specific case as it is unreliable --- .../test/script_tests/test_optimise_dipole_parameter.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/tests_and_analysis/test/script_tests/test_optimise_dipole_parameter.py b/tests_and_analysis/test/script_tests/test_optimise_dipole_parameter.py index 89bc389f2..d06b6b304 100644 --- a/tests_and_analysis/test/script_tests/test_optimise_dipole_parameter.py +++ b/tests_and_analysis/test/script_tests/test_optimise_dipole_parameter.py @@ -23,15 +23,6 @@ @pytest.mark.integration class TestRegression: - def test_optimal_is_0_75(self): - # Need a high-enough n to get a good timing, but - # can be slow for testing, so reduce the parameters that - # we test - optimal_dipole_parameter = calculate_optimum_dipole_parameter( - quartz_castep_bin, dipole_parameter_min=0.5, - dipole_parameter_max=1.25)[0] - assert optimal_dipole_parameter == 0.75 - def test_default_dipole_parameters(self): tested_parameters = calculate_optimum_dipole_parameter( quartz_castep_bin, n=5)[3]