Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cv::ORB::create() called with wrong arguments? #22

Open
seeocean2000 opened this issue Nov 3, 2015 · 1 comment
Open

cv::ORB::create() called with wrong arguments? #22

seeocean2000 opened this issue Nov 3, 2015 · 1 comment

Comments

@seeocean2000
Copy link

I am using OpenCV 2.4.11, and I think the argument list for cv::ORB::create() needs to be changed as in the following (you are missing a score type argument), but I don't know if this will actually change the results (probably not).

Index: src/akaze_compare.cpp
===================================================================
--- src/akaze_compare.cpp       (original)
+++ src/akaze_compare.cpp       (new)
@@ -154,7 +154,7 @@
 #else
   cv::Ptr orb = cv::ORB::create(ORB_MAX_KPTS, ORB_SCALE_FACTOR, ORB_PYRAMID_LEVELS,
 #endif
-    ORB_EDGE_THRESHOLD, ORB_FIRST_PYRAMID_LEVEL, ORB_WTA_K, ORB_PATCH_SIZE);
+    ORB_EDGE_THRESHOLD, ORB_FIRST_PYRAMID_LEVEL, ORB_WTA_K, cv::ORB::HARRIS_SCORE, ORB_PATCH_SIZE);
@pablofdezalc
Copy link
Owner

Thanks! Possibly it was a bug introduced when I added the compatibility of that script with different versions of OpenCV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants