Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use commenter username for from address of notifications #173

Open
dirkcuys opened this issue Jul 14, 2012 · 0 comments
Open

Use commenter username for from address of notifications #173

dirkcuys opened this issue Jul 14, 2012 · 0 comments
Labels

Comments

@dirkcuys
Copy link
Member

When a user replies to a comment, the username should be used in the from address. Ex. if john replied on a message, the from address should be set as "john [email protected]"

This will require that the module sending the notification needs to include the user that causes the notification. This may require some consideration to avoid complicating the notification interface unnecessarily.

See https://github.com/p2pu/lernanta/blob/master/lernanta/apps/notifications/tasks.py#L23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant