Skip to content
This repository has been archived by the owner on Nov 11, 2018. It is now read-only.

Get rid of a couple warning messages. #341

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Get rid of a couple warning messages. #341

wants to merge 4 commits into from

Conversation

lwandrebeck
Copy link

....

@p-e-w
Copy link
Owner

p-e-w commented Aug 20, 2014

Thank you for your effort here. I have to admit I'm a bit undecided as to whether I actually want to merge this. As it stands, this adds 15 lines of code with no benefit at all (as indicated in the comments, this is not "real" error handling) besides silencing the warnings, especially in the case of the regex which is almost guaranteed not to fail in practice. I merged such a PR before and have regretted it many times since as the try/catch clauses needlessly clutter up the code (and add indentation). The truth is that the valac (and gcc!) warnings are probably never going to disappear because Vala itself simply has too many bugs. What do you think, is the removal or a few warnings worth the clutter?

I'm not referring to the add_child fix here of course, that one makes perfect sense.

P.S.: For some reason your commit messages are doubled. Don't know what's going on here.

@p-e-w
Copy link
Owner

p-e-w commented Aug 20, 2014

To be honest, I have often considered removing most existing try/catch clauses to simplify the code at the cost of a few additional warning messages, which have never helped me in the past anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants