Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG Icons give error "Containers of type 'ArgosLineView' have no child property named 'y-fill'" #146

Open
Naahuel opened this issue Apr 9, 2023 · 2 comments · May be fixed by #151
Open

SVG Icons give error "Containers of type 'ArgosLineView' have no child property named 'y-fill'" #146

Naahuel opened this issue Apr 9, 2023 · 2 comments · May be fixed by #151

Comments

@Naahuel
Copy link

Naahuel commented Apr 9, 2023

When using a simple script that displays an SVG icon, the GNOME shell log gets completely filled with this error, which appears every time the script runs

pop-os gnome-shell[2252]: ../clutter/clutter/clutter-container.c:768: Containers of type 'ArgosLineView' have no child property named 'y-fill'

Script example:

#!/usr/bin/env bash

echo "Temp Icon\t | imageHeight=12 image=PHN2ZyB4bWxucz0naHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmcnIHZpZXdCb3g9JzAgMCAxMzUuNDY2NjcgMTM1LjQ2NjY3JyBoZWlnaHQ9JzY0JyB3aWR0aD0nNjQnPjxkZWZzPjxtYXJrZXIgb3JpZW50PSdhdXRvJyBpZD0nYicgb3ZlcmZsb3c9J3Zpc2libGUnPjxwYXRoIGQ9J00uOTggMGExIDEgMCAxIDEtMiAwIDEgMSAwIDAgMSAyIDB6JyBmaWxsPScjZjU1JyBmaWxsLXJ1bGU9J2V2ZW5vZGQnIHN0cm9rZT0nI2Y1NScgc3Ryb2tlLXdpZHRoPScuMjY3Jy8+PC9tYXJrZXI+PG1hcmtlciBvcmllbnQ9J2F1dG8nIGlkPSdhJyBvdmVyZmxvdz0ndmlzaWJsZSc+PHBhdGggZD0nTS45OCAwYTEgMSAwIDEgMS0yIDAgMSAxIDAgMCAxIDIgMHonIGZpbGw9JyNjY2MnIGZpbGwtcnVsZT0nZXZlbm9kZCcgc3Ryb2tlPScjY2NjJyBzdHJva2Utd2lkdGg9Jy4yNjcnLz48L21hcmtlcj48L2RlZnM+PGcgc3Ryb2tlLXdpZHRoPScxNC43NzknPjxwYXRoIGQ9J002Ni4zNzggMTEyLjU5NmMuMDEzLTMxLjcyNi4wMjctNS42My4wNC05NS4yMzUnIGZpbGw9JyNjY2MnIHN0cm9rZT0nI2NjYycgc3Ryb2tlLWxpbmVjYXA9J3JvdW5kJyBtYXJrZXItc3RhcnQ9J3VybCgjYSknIHRyYW5zZm9ybT0ndHJhbnNsYXRlKC0xLjE4MiAtNC42ODcpIHNjYWxlKDEuMDM4MjQpJy8+PHBhdGggZD0nTTY2LjM3OCAxMTIuNTk2Yy4wMi0xNi4zMzguMDQtMi45LjA2LTQ5LjA0MycgZmlsbD0nI2Y1NScgc3Ryb2tlPScjZjU1JyBtYXJrZXItc3RhcnQ9J3VybCgjYiknIHRyYW5zZm9ybT0ndHJhbnNsYXRlKC0xLjE4MiAtNC42ODcpIHNjYWxlKDEuMDM4MjQpJy8+PC9nPjwvc3ZnPgo=c@t"

That base64 string is this SVG icon:

<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 135.46667 135.46667' height='64' width='64'><defs><marker orient='auto' id='b' overflow='visible'><path d='M.98 0a1 1 0 1 1-2 0 1 1 0 0 1 2 0z' fill='#f55' fill-rule='evenodd' stroke='#f55' stroke-width='.267'/></marker><marker orient='auto' id='a' overflow='visible'><path d='M.98 0a1 1 0 1 1-2 0 1 1 0 0 1 2 0z' fill='#ccc' fill-rule='evenodd' stroke='#ccc' stroke-width='.267'/></marker></defs><g stroke-width='14.779'><path d='M66.378 112.596c.013-31.726.027-5.63.04-95.235' fill='#ccc' stroke='#ccc' stroke-linecap='round' marker-start='url(#a)' transform='translate(-1.182 -4.687) scale(1.03824)'/><path d='M66.378 112.596c.02-16.338.04-2.9.06-49.043' fill='#f55' stroke='#f55' marker-start='url(#b)' transform='translate(-1.182 -4.687) scale(1.03824)'/></g></svg>

  • Ubuntu 22.04 (fresh install of Pop OS 22.04)
  • GNOME Shell 42.5
@onstrt
Copy link

onstrt commented Oct 16, 2023

In my case there are no .SVG icons.. #!/usr/bin/env bash ..

./clutter/clutter/clutter-container.c:768: Containers of type 'Gjs_argos_pew_worldwidemann_com_lineview_ArgosLineView' have no child property named 'y-fill'

Ubuntu 22.04.3 LTS
GNOME Shell 42.9

@real-or-random
Copy link

I've been getting the same message forever with an SVG icon (haven't tried without).

I assume it's this line:

argos/[email protected]/lineview.js

Lines 79 to 80 in e2d68ea

// Do not stretch the texture to the height of the container
this.child_set_property(texture, "y-fill", false);

I had a PR for a different problem, but I also had changed this line on the fly. This PR was closed because we couldn't reproduce the underlying issue, but I suspect part of it solves this issue here. In particular, the highlighted part of the commit should do the trick: https://github.com/p-e-w/argos/pull/106/files?diff=split&w=0#diff-fe5b5cf43ffbec6d1618aa84be67e235447b148d8138100e48f1d4830b132421L76-R84

I can open a PR, but it will probably require some testing with non-rectangular icons.

real-or-random added a commit to real-or-random/argos that referenced this issue Nov 2, 2023
@real-or-random
Don't set obsolete y-fill property for icons
0e2988b 
No replacement seems to be necessary. My testing shows that no
stretching is performed anyway.

Fixes p-e-w#146.
@real-or-random real-or-random linked a pull request Nov 2, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't set obsolete y-fill property for icons real-or-random/argos
3 participants
@real-or-random @Naahuel @onstrt