Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

Season winner is not registered on month end #113

Open
oyvinddd opened this issue Nov 2, 2022 · 6 comments
Open

Season winner is not registered on month end #113

oyvinddd opened this issue Nov 2, 2022 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@oyvinddd
Copy link
Owner

oyvinddd commented Nov 2, 2022

Right now there's a bug in the CF that prevents this from happening. Please fix, as adding winners manually to the DB is very tedious and error prone.

@oyvinddd oyvinddd added the bug Something isn't working label Nov 2, 2022
@oyvinddd oyvinddd changed the title Season winner is not registered upon month end Season winner is not registered on month end Nov 2, 2022
@Bruswei
Copy link
Collaborator

Bruswei commented Nov 2, 2022

Did a test run, seasonal winner function works just fine with current season (5 players only). Might be some corrupted user data. Have to test a bit more later on this season.

@oyvinddd
Copy link
Owner Author

oyvinddd commented Nov 3, 2022

hmm... strange.. maybe the cloud function just didn't run as expected on month end then?

@oyvinddd
Copy link
Owner Author

oyvinddd commented Nov 3, 2022

or, as you said, there might be some 'legacy'/corrupted users involved that don't have all the correct fields.

@Bruswei
Copy link
Collaborator

Bruswei commented Nov 6, 2022

Added more logs for seasonal winner calculation for now so we can take a better look by end of this month.

@oyvinddd
Copy link
Owner Author

oyvinddd commented Nov 6, 2022

Might as well create a PR for this so that what's currently deployed to Firebase is identical the main branch.

@Bruswei
Copy link
Collaborator

Bruswei commented Nov 6, 2022

Pull request created here: #114

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants